Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Ads): Add CUEPOINTS_CHANGED event to interstitials #6791

Merged
merged 5 commits into from
Jun 12, 2024
Merged

feat(Ads): Add CUEPOINTS_CHANGED event to interstitials #6791

merged 5 commits into from
Jun 12, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 11, 2024

No description provided.

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Jun 11, 2024
@avelad avelad added this to the v4.10 milestone Jun 11, 2024
@avelad avelad requested review from theodab and joeyparrish June 11, 2024 08:55
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jun 11, 2024 •
edited
Loading

Incremental code coverage: 62.12%

theodab
theodab requested changes Jun 12, 2024
View reviewed changes
lib/ads/interstitial_ad_manager.js Outdated Show resolved Hide resolved
lib/ads/interstitial_ad_manager.js Outdated Show resolved Hide resolved
lib/ads/interstitial_ad_manager.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab June 12, 2024 07:04
@avelad avelad merged commit 9b25ff5 into shaka-project:main Jun 12, 2024
14 of 15 checks passed
@avelad avelad deleted the interstitials-cuepoints-changed branch June 12, 2024 08:15
@shaka-bot shaka-bot mentioned this pull request Jun 12, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 11, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab